feat: add i18n support for default error messages #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is some really great looking work so far. I'm glad you opened this cause I don't use gettext much. Just assign me for review whenever you're ready for me to formally review. Only request I have is that it would be nice if we could have some tests around this. |
|
@srcrip I'll add tests in the demo folder and I ping you when it is done |
|
@srcrip I added the test but I don't have permission to assign you as a reviewer. |
|
Wonderful! I'll take a look. |
|
@srcrip do you have any idea when you'll be able to review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@srcrip I test locally with a project of mine and it works as expected.
Please let me know if you don't like the direction of the solution and I can try to explore other ideas.
closes #13