Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hability to customize group toast classes #8

Closed

Conversation

nelsonmestevao
Copy link
Contributor

@nelsonmestevao nelsonmestevao commented Jun 10, 2024

In my use case the need is related with the outside padding but I think it can be useful in other situations. This allows more freedom.

I am happy to improve anything that might not be following some expectation that I did not antecipate.

@sergchernata
Copy link

We need this right now, as well. In our case it's because we need to position the toast container as absolute, not fixed.

@srcrip
Copy link
Owner

srcrip commented Jul 3, 2024

Thank you! I will get this merged ASAP. I just want to give it a good review. Sorry I didn't see it earlier, my GH notifications just failed me.

@curtisault
Copy link

curtisault commented Jul 4, 2024

We need this right now, as well. In our case it's because we need to position the toast container as absolute, not fixed.

Can you not resolve this in the immediate by wrapping the component in the root app.html.heex with a span or div using class="absolute"?

image

@srcrip
Copy link
Owner

srcrip commented Jul 6, 2024

Thank you very much for your pr @nelsonmestevao. I ended up wanting to tweak things a little bit more, so I added the changes in f1d86a1. I hope you're not too disappointed if you wanted the contributor badge. If you make another improvement I'd be happy to merge it.

Let me know if that resolves what you need to do and we can close this, or if you need to add something else we can tweak this branch and merge it.

@srcrip
Copy link
Owner

srcrip commented Jul 6, 2024

Note that I have not released it yet so you'd have to point at master to try it out. It'd be great if you let me know if it works before I release it, but I may release it before then if I get too eager 😂

@nelsonmestevao
Copy link
Contributor Author

Hey @srcrip, no worries :P

Thank you for improving this part. I will test and let you know soon 🙏

@nelsonmestevao
Copy link
Contributor Author

Hey @srcrip, it works perfectly for my use case. Thank you very much 🙇

@nelsonmestevao nelsonmestevao deleted the ne/group-classes branch July 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants