Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Ember documentation #1948

Open
wants to merge 9 commits into
base: devel
Choose a base branch
from
Open

Adding Ember documentation #1948

wants to merge 9 commits into from

Conversation

nab880
Copy link

@nab880 nab880 commented Oct 14, 2022

Adding ember documentation and examples

Erase this information and put your Pull Request comments here

Instructions for Issuing a Pull Request to sst-elements

1 - Verify that the Pull Request is targeted to the devel branch of sstsimulator/sst-elements

2 - Verify that Source branch is up to date with the devel branch of sst-elements

3 - After submitting your Pull Request:

  • Automatic Testing will commence in a short while
    • Pull Requests will be tested with the devel branches of the sst-core and sst-sqe repositories
      • These branches are syncronized with the devel branch of sst-elements. This is why is it important to keep your source branch up to date.
    • If testing passes, the source branch will be automatically merged (if possible)
      • Pull Requests from forks will not be automatically tested until the code is inspected.
      • Pull Requests from forks will not be automatically merged into the devel branch.
    • If testing fails, You will be notified of the test results.
      • The Pull Request will be retested on a regular basis - Changes to the source branch can be made to correct problems

4 - DO NOT DELETE THE BRANCH (OR FORKED REPO) UNTIL THE PULL REQUEST IS MERGED.

nab880 and others added 2 commits October 14, 2022 13:18
@nab880
Adding Ember documentation
efec15c 
Adding ember documentation and examples
@nab880
Update Makefile.am
a604b95
@sst-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

jpkenny
jpkenny requested changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@jpkenny jpkenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the makefile problem and I'll release the pre-check requirement

src/sst/elements/ember/Makefile.am Outdated Show resolved Hide resolved
nab880 and others added 3 commits October 14, 2022 14:04
@nab880
Adding Ember documentation
6ae5d8e 
Adding ember documentation and examples

Update Makefile.am
@nab880
Update Makefile.am
f5a4ac1
@nab880
Merge branch 'add-ember-documentation' of https://github.com/nab880/s…
5f59027 
…st-elements into add-ember-documentation
jpkenny
jpkenny approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@jpkenny jpkenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sst-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed.

@sst-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-11.6-XC13-ARM_OMPI-4.0.5_PY3.9_sst-elements

  • Build Num: 83
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements

  • Build Num: 696
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_Make-Dist

  • Build Num: 450
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MT-2

  • Build Num: 682
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MR-2

  • Build Num: 681
  • Status: STARTED

Using Repos:

Repo: ELEMENTS (nab880/sst-elements)
  • Branch: add-ember-documentation
  • SHA: 5f59027
  • Mode: TEST_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: b6e8c5652bf9840e695a66fb3317290e1918f9de
  • Mode: SUPPORT_REPO
Repo: CORE (sstsimulator/sst-core)
  • Branch: devel
  • SHA: dac3c8ecee195658341362b3a66933c770cd3271
  • Mode: SUPPORT_REPO
Repo: MACRO (sstsimulator/sst-macro)
  • Branch: devel
  • SHA: 28aef39f18a32c56187c443837798270c9499ac8
  • Mode: SUPPORT_REPO

Pull Request Author: nab880

@sst-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 4 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Job: SST__AutotestGen2_NewFW_OSX-11.6-XC13-ARM_OMPI-4.0.5_PY3.9_sst-elements

  • Result: FAILED
  • Build #: 83
  • URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_OSX-11.6-XC13-ARM_OMPI-4.0.5_PY3.9_sst-elements/83/consoleFull
  • Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements

  • Result: FAILED
  • Build #: 696
  • URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements/696/consoleFull
  • Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_Make-Dist

  • Result: FAILED
  • Build #: 450
  • URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_Make-Dist/450/consoleFull
  • Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MT-2

  • Result: FAILED
  • Build #: 682
  • URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MT-2/682/consoleFull
  • Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MR-2

  • Result: FAILED
  • Build #: 681
  • URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MR-2/681/consoleFull
  • Job: - Status: FAILURE

@sst-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-11.6-XC13-ARM_OMPI-4.0.5_PY3.9_sst-elements

  • Build Num: 84
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements

  • Build Num: 697
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_Make-Dist

  • Build Num: 451
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MT-2

  • Build Num: 683
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MR-2

  • Build Num: 682
  • Status: STARTED

Using Repos:

Repo: ELEMENTS (nab880/sst-elements)
  • Branch: add-ember-documentation
  • SHA: 5f59027
  • Mode: TEST_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: b6e8c5652bf9840e695a66fb3317290e1918f9de
  • Mode: SUPPORT_REPO
Repo: CORE (sstsimulator/sst-core)
  • Branch: devel
  • SHA: dac3c8ecee195658341362b3a66933c770cd3271
  • Mode: SUPPORT_REPO
Repo: MACRO (sstsimulator/sst-macro)
  • Branch: devel
  • SHA: 28aef39f18a32c56187c443837798270c9499ac8
  • Mode: SUPPORT_REPO

Pull Request Author: nab880

@sst-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 4 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Job: SST__AutotestGen2_NewFW_OSX-11.6-XC13-ARM_OMPI-4.0.5_PY3.9_sst-elements

  • Result: FAILED
  • Build #: 84
  • URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_OSX-11.6-XC13-ARM_OMPI-4.0.5_PY3.9_sst-elements/84/consoleFull
  • Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements

  • Result: FAILED
  • Build #: 697
  • URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements/697/consoleFull
  • Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_Make-Dist

  • Result: FAILED
  • Build #: 451
  • URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_Make-Dist/451/consoleFull
  • Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MT-2

  • Result: FAILED
  • Build #: 683
  • URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MT-2/683/consoleFull
  • Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MR-2

  • Result: FAILED
  • Build #: 682
  • URL: Jenkins server at https://jenkins-srn.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.0.5_PY3.6_sst-elements_MR-2/682/consoleFull
  • Job: - Status: FAILURE

jpkenny
jpkenny reviewed Oct 15, 2022
View reviewed changes
src/sst/elements/ember/example/motifs/emberexample.h Outdated
namespace SST {
namespace Ember {

class Foo : public EmberMessagePassingGenerator {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foo -> Example
@nab880

@jpkenny jpkenny added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkenny jpkenny jpkenny approved these changes

Assignees
No one assigned
Labels
AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) SST-ember
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nab880 @sst-autotester @jpkenny @hughes-c