Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ecsw 2793- terraform resource implementation for allocations and allocation_claims #44

Conversation

maheshtambe
Copy link
Contributor

@maheshtambe maheshtambe commented May 16, 2024

Summary-:

  • Implemented stackpath_compute_network_allocation and stackpath_compute_network_allocation_claim terraform resources to manage allocation and allocation_claims in SP// edge cloud.
  • Added examples to verify creation of allocation and allocation_claim for various supported scenarios.
  • Added acceptance tests to test allocation/allocation_claim resources. Note- acceptance test files were tested against staging ipam api.
  • PR includes updates to client/models code for existing resources like network policy, routes etc as they have come due to some changes in openapi spec changes for those API's.

Copy link
Contributor

@jtway jtway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really just did a once through on the files. I'm not sure I'm the best to ensure all logic is correct in the implementation for the allocations and allocation claims. Overall, it does look good, without a couple minor asks.

# label. Only the "in" operator is supported.
operator = "in"
# The values that the label value should be compared to
values = ["EC4LAB01"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to change this and the one below as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, addressed in 26f06b0

Copy link
Contributor

@jtway jtway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, and exciting to see these additions!

@maheshtambe maheshtambe merged commit b06113a into integration/network-allocations May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants