-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ecsw 2793- terraform resource implementation for allocations and allocation_claims #44
Feature/ecsw 2793- terraform resource implementation for allocations and allocation_claims #44
Conversation
… tf file in staging env
…resources, updated tf exmaple to cover allocation claim scenarios
…erationToBeDone api
… validation for claim's allocation field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really just did a once through on the files. I'm not sure I'm the best to ensure all logic is correct in the implementation for the allocations and allocation claims. Overall, it does look good, without a couple minor asks.
# label. Only the "in" operator is supported. | ||
operator = "in" | ||
# The values that the label value should be compared to | ||
values = ["EC4LAB01"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to change this and the one below as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, addressed in 26f06b0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, and exciting to see these additions!
Summary-:
stackpath_compute_network_allocation
andstackpath_compute_network_allocation_claim
terraform resources to manage allocation and allocation_claims in SP// edge cloud.