Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter to overwrite the default response timeout. #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thiagosanches
Copy link

Noticed that for some BLC_UNKNOWN errors it were related to the response timeout, in order to avoid that
added an option to overwrite the default response timeout.

Noticed that for some BLC_UNKNOWN errors it were related to the response timeout, in order to avoid that
added an option to overwrite the default response timeout.
@thiagosanches
Copy link
Author

thiagosanches commented Mar 1, 2019

Evidence regarding the response timeout:
image

It could be some instability on the network from the host that issued the command, but this causes the BLC_UNKNOWN and after increasing the response time I was able run properly.

@arthurvi
Copy link

This is working fine for me. Can it be merged? @stevenvachon

@Zauberbutter
Copy link

Would solve #83 and #63 I think.

@stevenvachon stevenvachon force-pushed the master branch 11 times, most recently from f7f6233 to fc31ac1 Compare July 22, 2019 22:29
@stevenvachon stevenvachon force-pushed the master branch 15 times, most recently from 7d35cc4 to 4377053 Compare July 29, 2019 21:34
@HarshalRathore
Copy link

@thiagosanches
if you have added the response time-out feature or changed the default response time-out. what is the syntax to use it i tried using npx broken-link-checker https://open-horizon.github.io/ --ordered --recursive --response-timeout 10000 but it still hanged

@thiagosanches
Copy link
Author

thiagosanches commented Sep 24, 2021

@thiagosanches
if you have added the response time-out feature or changed the default response time-out. what is the syntax to use it i tried using npx broken-link-checker https://open-horizon.github.io/ --ordered --recursive --response-timeout 10000 but it still hanged

Hey, Did you have the chance to test it using my branch? It's not merged into master yet.

@Harshalrathore007
Copy link

@thiagosanches
if you have added the response time-out feature or changed the default response time-out. what is the syntax to use it i tried using npx broken-link-checker https://open-horizon.github.io/ --ordered --recursive --response-timeout 10000 but it still hanged

Hey, Did you have the chance to test it using my branch? It's not merged into master yet.

How can I test your changes if they are still not merged into the master branch. Sorry I am new to Open-source, git & github.
Actually I was recently given my first issue, its to create a GitHub action that will check for broken links and if it finds any it will create a broken-link issue. Can you give me some advice it will be helpful. Thank you

@thiagosanches
Copy link
Author

@thiagosanches
if you have added the response time-out feature or changed the default response time-out. what is the syntax to use it i tried using npx broken-link-checker https://open-horizon.github.io/ --ordered --recursive --response-timeout 10000 but it still hanged

Hey, Did you have the chance to test it using my branch? It's not merged into master yet.

How can I test your changes if they are still not merged into the master branch. Sorry I am new to Open-source, git & github.
Actually I was recently given my first issue, its to create a GitHub action that will check for broken links and if it finds any it will create a broken-link issue. Can you give me some advice it will be helpful. Thank you

Hey @HarshalRathore , no worries! Basically, you can clone my fork and use that branch to test it. Something link this:

git clone [email protected]:thiagosanches/broken-link-checker.git
npm i 
<run blc here with my parameter>

I hope that helps you!

Thanks,
Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants