Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

bugfix: fix extensions function name #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mogmet
Copy link
Contributor

@mogmet mogmet commented Sep 13, 2022

The function names used in extension have been changed.
In this PR, the function names have been modified to follow the changes.

https://github.com/stripe/stripe-firebase-extensions/blob/b2d6f244b378e117630a4adbb50aabf21961b525/firestore-stripe-payments/CHANGELOG.md#version-0115---2021-08-26

@mogmet mogmet changed the title bugfix: fix extension name bugfix: fix extensions function name Sep 13, 2022
@mogmet
Copy link
Contributor Author

mogmet commented Sep 18, 2022

@thorsten-stripe
Can I have this PR reviewed?

@mogmet
Copy link
Contributor Author

mogmet commented Oct 4, 2022

@thorsten-stripe @cjavilla-stripe
Can I have this PR reviewed?

@labnol
Copy link

labnol commented Nov 13, 2022

If you are getting any CORS errors in the Stripe Firebase app, it is due to this incorrect Firebase function name. You can make the change manually in your app.js file until Stripe devs merge this PR.

Before

    const functionRef = firebase
      .app()
      .functions(functionLocation)
      .httpsCallable('ext-firestore-stripe-subscriptions-createPortalLink');
    const { data } = await functionRef({ returnUrl: window.location.origin });
    window.location.assign(data.url);
  });

After

    const functionRef = firebase
      .app()
      .functions(functionLocation)
      .httpsCallable('ext-firestore-stripe-payments-createPortalLink');
    const { data } = await functionRef({ returnUrl: window.location.origin });
    window.location.assign(data.url);
  });

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants