Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spelling workflow #343

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Add spelling workflow #343

merged 4 commits into from
Aug 30, 2023

Conversation

szepeviktor
Copy link
Contributor

Add https://github.com/crate-ci/typos as a CI workflow.

Could you configure it?

@szepeviktor
Copy link
Contributor Author

Could you configure it?

Okay ... I contribute the configuration file too.

@robdekort
Copy link
Contributor

Thanks, I'll have a look when I find some time. Could be I won't merge this because I don't want to overcomplicate stuff. No hard feelings pls :-).

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Aug 28, 2023

I don't want to overcomplicate stuff.

This is just 1 puny workflow!!!

These 27 jobs are called "overcomplication" 😱 https://github.com/szepeviktor/byte-level-care/tree/master/.github/workflows


2 more typos 👇🏻

@robdekort
Copy link
Contributor

This is just 1 puny workflow!!!

Point is I don't know anything about workflows, what they do, how they work etc, and I'm the one maintain this thing. Also this potentially opens the door to 20 others who all just want one puny workflow added. I'll have a look soon. Thanks.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Aug 28, 2023

No hard feelings pls :-)

All right, all right.

@robdekort
Copy link
Contributor

Giving it a shot. Curious to see how it works in practice. Can always remove it annoys me too much ;-).

Thanks, appreciated.

@robdekort robdekort merged commit 8aa93be into studio1902:main Aug 30, 2023
1 check passed
@szepeviktor szepeviktor deleted the patch-1 branch August 30, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants