Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go formatting issue, fix typo #6

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Fix go formatting issue, fix typo #6

merged 2 commits into from
Jan 12, 2024

Conversation

deining
Copy link
Contributor

@deining deining commented Jan 11, 2024 •
edited
Loading

This PR fixes a typo I spotted in the project.
It also resolves go formatting issues.

subpop
subpop requested changes Jan 12, 2024
View reviewed changes
Copy link
Owner

@subpop subpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! There's one small change I'd like you to consider. It looks like some auto-space formatting changes got caught up in your commit.

encode.go Show resolved Hide resolved
@deining deining requested a review from subpop January 12, 2024 16:20
@deining deining changed the title fix typo Fix go formatting issue, fix typo Jan 12, 2024
@deining
Copy link
Contributor Author

deining commented Jan 12, 2024

This PR should be ready for merging now.

@subpop subpop merged commit 3c83590 into subpop:main Jan 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subpop subpop subpop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deining @subpop