feat(typegen): relationships for views #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unused, and it no longer serves as a unique identifier once combined with view relationships
Generate types for relationships from views to tables, tables to views, and views to views.
soedirgo
force-pushed
the
feat/view-relationships
branch
from
71b8498
to
8d24b00
Compare
sweatybridge
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Generate types for relationships from views to tables, tables to views, and views to views. Most of the logic for this comes from https://github.com/PostgREST/postgrest/blob/main/src/PostgREST/SchemaCache.hs
What is the current behavior?
Only relationships between tables are generated.
What is the new behavior?
All relationships except computed relationships are supported.
Additional context
supabase/postgrest-js#303