Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: queue hours default env #513

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix: queue hours default env #513

merged 1 commit into from
Jul 3, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Jul 3, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

The default value of undefined of pgQueueDeleteAfterHours conflicts with pgBoss default values.

What is the new behavior?

  • only include pgQueueDeleteAfterHours if defined
  • code neats

@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9775384580

Details

  • 4 of 9 (44.44%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 79.331%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/internal/queue/queue.ts 0 5 0.0%
Totals Coverage Status
Change from base Build 9763333553: -0.02%
Covered Lines: 12948
Relevant Lines: 16187

💛 - Coveralls

@fenos fenos merged commit aa8c58b into master Jul 3, 2024
1 check passed
@fenos fenos deleted the fix/default-queue-env branch July 3, 2024 14:03
Copy link

github-actions bot commented Jul 3, 2024

🎉 This PR is included in version 1.6.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants