Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom metadata on upload #518

Merged
merged 1 commit into from
Jul 9, 2024
Merged

feat: custom metadata on upload #518

merged 1 commit into from
Jul 9, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Jul 8, 2024

What kind of change does this PR introduce?

Feature

What is the new behavior?

We can now pass custom metadata (up to 1MB) to:

  • Standard uploads
  • Tus Uploads
  • S3 Uploads

FInally closes #439

Copy link

github-actions bot commented Jul 9, 2024

Pull Request Test Coverage Report for Build 9853257202

Details

  • 197 of 235 (83.83%) changed or added relevant lines in 17 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 79.511%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/routes/object/getObjectInfo.ts 12 14 85.71%
src/http/routes/s3/commands/create-multipart-upload.ts 9 11 81.82%
src/storage/renderer/head.ts 11 13 84.62%
src/http/routes/tus/lifecycle.ts 16 21 76.19%
src/storage/protocols/s3/s3-handler.ts 56 62 90.32%
src/internal/database/connection.ts 0 7 0.0%
src/storage/uploader.ts 23 37 62.16%
Files with Coverage Reduction New Missed Lines %
src/http/routes/tus/lifecycle.ts 1 87.46%
src/internal/database/connection.ts 1 74.34%
Totals Coverage Status
Change from base Build 9806495479: 0.2%
Covered Lines: 13140
Relevant Lines: 16376

💛 - Coveralls

@@ -0,0 +1,2 @@
ALTER TABLE storage.objects ADD COLUMN user_metadata jsonb NULL;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auth seems to have it as raw_user_meta_data but personally think user_metadata reads better

migrations/tenant/0025-custom-metadata.sql Outdated Show resolved Hide resolved
@fenos fenos force-pushed the feat/custom-metadata branch 3 times, most recently from 6d0a28e to 2f935a0 Compare July 9, 2024 12:59
@fenos fenos merged commit d0f0348 into master Jul 9, 2024
1 check passed
@fenos fenos deleted the feat/custom-metadata branch July 9, 2024 14:38
Copy link

github-actions bot commented Jul 9, 2024

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Gbillington1
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add file_metadata field to objects schema
3 participants