Allow chunking map call to take in sublists of length 10 and support lists as inputs #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-nightly[bot]](https://avatars.githubusercontent.com/in/324098?s=60&v=4){kind=small}
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
GitHub actions yielded the following error. The relevant lines from the logs are: The command that failed is There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The relevant lines from the logs are: The command that failed is There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The relevant lines from the logs are: The command that failed is There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The relevant lines from the logs are: The command that failed is There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The command that failed is This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The command that failed is This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The command that failed is This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
1 similar comment
|
GitHub actions yielded the following error. The command that failed is This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
kevinlu1248
reviewed
Aug 3, 2023
|
GitHub actions yielded the following error. The relevant lines from the logs are: The command that failed is There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
|
GitHub actions yielded the following error. The relevant lines from the logs corresponding to the error are: The command that failed is This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
|
GitHub actions yielded the following error. The relevant lines from the logs corresponding to the error are: The command that failed is This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
kevinlu1248
reviewed
Aug 3, 2023
|
GitHub actions yielded the following error. The relevant lines from the logs corresponding to the error are: The command that failed is This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR. |
kevinlu1248
reviewed
Aug 3, 2023
pyproject.toml
Outdated
| PyGithub = "1.58.2" | ||
| loguru = "^0.6.0" | ||
| python = "^3.10" # or another compatible version | ||
| PyGithub = "1.58.3" # or another compatible version |
|
|
GitHub actions yielded the following error. The relevant lines from the logs are: The command that failed is There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue. This is likely a linting or type-checking issue with the source code but if you are updating the GitHub Actions or versioning, this could be an issue with the GitHub Action yaml files. |
kevinlu1248
reviewed
Aug 4, 2023
sweepai/utils/utils.py
Outdated
| @@ -215,6 +215,24 @@ def __enter__(self): | |||
|
|
|||
| @method() | |||
| def chunk( | |||
| self, | |||
| file_content: Union[str, List[str]], | |||
There was a problem hiding this comment.
Use | instead of Union and list instead of List
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the map function in the chunker to support sublists of length 10 and lists as inputs. The current implementation of the map function in
utils/utils.pydoes not handle these types of inputs. This PR adds the necessary checks and logic to process each item in the list or sublist accordingly.Summary of Changes
Please review and merge this PR. Thank you!
Fixes #936.
To checkout this PR branch, run the following command in your terminal:
To make tweaks to this pull request, leave a comment below or in the code.