Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isListening public API #59

Merged
merged 1 commit into from
Jun 8, 2023
Merged

isListening public API #59

merged 1 commit into from
Jun 8, 2023

Conversation

swhitty
Copy link
Owner

@swhitty swhitty commented Jun 8, 2023

Makes the existing var isListening: Bool property of HTTPServer public as suggested by @Aayush9029 in #58

While this is very similar to the existing throwing method:

try await server.waitUntilListening()

I think the Bool property can read nicer than throws in some scenarios:

await server.isListening

@swhitty swhitty merged commit 7cfff2f into main Jun 8, 2023
16 of 17 checks passed
@swhitty swhitty deleted the isListening branch June 8, 2023 07:42
@swhitty swhitty linked an issue Jun 8, 2023 that may be closed by this pull request
isRunning: Ability to see if the server instance is currently running or not. #58
Closed
@Aayush9029
Copy link

You’re awesome ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isRunning: Ability to see if the server instance is currently running or not.
2 participants
@swhitty @Aayush9029