Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SocketPool + IdentifiableContinuation #84

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Conversation

swhitty
Copy link
Owner

@swhitty swhitty commented Apr 14, 2024

Replaces usage of CancellingContinuation with IdentifiableContinuation within SocketPool when suspending sockets.

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.61%. Comparing base (b88a360) to head (6bc04ea).

Files Patch % Lines
FlyingSocks/Sources/SocketPool.swift 96.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   99.71%   99.61%   -0.10%     
==========================================
  Files          48       48              
  Lines        2090     2096       +6     
==========================================
+ Hits         2084     2088       +4     
- Misses          6        8       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swhitty swhitty marked this pull request as draft April 14, 2024 06:51
@swhitty swhitty marked this pull request as ready for review April 14, 2024 06:55
@swhitty swhitty force-pushed the socket-pool-continuation branch 2 times, most recently from 71c85f9 to 0fecc03 Compare April 14, 2024 08:48
@swhitty swhitty merged commit 3e01f1d into main Apr 14, 2024
12 of 14 checks passed
@swhitty swhitty deleted the socket-pool-continuation branch April 14, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant