Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New IMU message draft [SEN-735] #1186

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reimerix
Copy link
Contributor

@reimerix reimerix commented Jul 7, 2022

Description

This is a draft/RFC for potential successors to our current IMU messages.

@reimerix reimerix requested review from woodfell and ebethon July 7, 2022 14:43
Milliseconds since reference epoch, fractional part
- acc_x:
type: s32
units: 0.000000228406861 m/s^2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the documentation, it will be easier to specify the fraction instead of the decimal value

desc: Acceleration in the IMU frame X axis
- acc_y:
type: s32
units: 0.000000228406861 m/s^2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the documentation, it will be easier to specify the fraction instead of the decimal value

desc: Acceleration in the IMU frame Y axis
- acc_z:
type: s32
units: 0.000000228406861 m/s^2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the documentation, it will be easier to specify the fraction instead of the decimal value

desc: Acceleration in the IMU frame Z axis
- gyr_x:
type: s32
units: 0.000003725290298 deg/s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the documentation, it will be easier to specify the fraction instead of the decimal value

desc: Angular rate around IMU frame X axis
- gyr_y:
type: s32
units: 0.000003725290298 deg/s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the documentation, it will be easier to specify the fraction instead of the decimal value

desc: Angular rate around IMU frame Y axis
- gyr_z:
type: s32
units: 0.000003725290298 deg/s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the documentation, it will be easier to specify the fraction instead of the decimal value

desc: Health and status flags
fields:
- 0:
desc: IMU health indicator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you expect the IMU data generator to populate this field?

desc: Health and status flags
fields:
- 0:
desc: IMU health indicator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you expect the IMU data generator to populate this field?

type: u16
units: 0.004 K
desc: temperature difference from -60 degrees Celsius - use 0xFF for invalid
- flags:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High rate data also contains a flags field with much the same items in it. Is it needed here as well?

- temperature:
type: u16
units: 0.004 K
desc: temperature difference from -60 degrees Celsius - use 0xFF for invalid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
desc: temperature difference from -60 degrees Celsius - use 0xFF for invalid
desc: temperature difference from -60 degrees Celsius - use 0xFFFF for invalid

- imu_id:
type: u8
desc: Identifier of current IMU, e.g. to differentiate between multiple IMUs in the same vehicle
- imu_type:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need IMU type? The fields in here seem generic enough that we shouldn't need to process it differently based on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants