-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebWorkerTaskExecutor
#256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebWorkerTaskExecutor is an implementation of `TaskExecutor` protocol, which is introduced by [SE-0417] since Swift 6.0. This task executor runs tasks on Worker threads, which is useful for offloading computationally expensive tasks from the main thread. The `WebWorkerTaskExecutor` is designed to work with [Web Workers API] and Node.js's [`worker_threads` module]. [SE-0417]: https://github.com/swiftlang/swift-evolution/blob/main/proposals/0417-task-executor-preference.md [Web Workers API]: https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API [`worker_threads` module]: https://nodejs.org/api/worker_threads.html
Time Change: +399ms (4%) Total Time: 9,570ms
View Unchanged
View Baselines
|
kateinoigakukun
force-pushed
the
yt/web-worker-executor
branch
from
July 6, 2024 10:59
aec76ce
to
e3181b0
Compare
For now, the data is not used in the worker thread, but it can be used in the future.
Seems like blocking the main thread also blocks the Web Worker threads from starting on some browsers.
CC: @ephemer might be interested in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebWorkerTaskExecutor is an implementation of
TaskExecutor
protocol, which is introduced by SE-0417 since Swift 6.0. This task executor runs tasks on Worker threads, which is useful for offloading computationally expensive tasks from the main thread.The
WebWorkerTaskExecutor
is designed to work with Web Workers API and Node.js'sworker_threads
module.This depends on swiftlang/swift#75008
Example
Try it out: https://swiftwasm-threading-example.vercel.app/
Source: https://github.com/kateinoigakukun/swiftwasm-threading-example/
Usage
Also JavaScript-side needs some tweaks:
Dataflow overview
Known limitations
@MainActor
does not hop back to main threadDue to an issue in Cooperative global executor,
@MainActor
andMainActor.run
don't switch execution thread whenWebWorkerTaskExecutor
is preferred.JSObject
instance cannot cross the thread boundaryDue to the underlying Web Worker limitation, JavaScript objects (
JSObject
) cannot be shared with or transferred to another thread. You need to convert it into Swift-native objects to represent it in shared memory space.TODO