Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved: PHP Version #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improved: PHP Version #23

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51d2265
Improved: PHP Version
Jan 24, 2019
e5d54be
Improved: PHP Version (i18n)
Jan 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion assets/dashboard.index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,4 +306,16 @@ table.skinny th {
border-bottom: 1px solid #ccc;
padding: 2px 5px 8px 5px;
line-height: 1;
}
}

.status-notice {
color: #f9ba4b;
}

.status-ok {
color: #90c648;
}

.status-error {
color: #c4301e;
}
6 changes: 3 additions & 3 deletions extension.driver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,13 +525,13 @@ public function render_panel($context) {
$version = phpversion();
if ($ver > 7.0) {
$dl->appendChild(new XMLElement('dt', __('PHP Version')));
$dl->appendChild(new XMLElement('dd', '<span style="color:green">' . $version . '</span>'));
$dl->appendChild(new XMLElement('dd', '<span class="status-ok">' . $version . '</span>'));
} elseif ($ver === 7.0) {
$dl->appendChild(new XMLElement('dt', __('PHP Version')));
$dl->appendChild(new XMLElement('dd', '<span style="color:orange">' . $version . '<br />Please go to your server management and check if a newer PHP version is available.</span>'));
$dl->appendChild(new XMLElement('dd', '<span class="status-notice">' . $version . '<br />Please go to your server management and check if a newer PHP version is available.</span>'));
} else {
$dl->appendChild(new XMLElement('dt', __('PHP Version')));
$dl->appendChild(new XMLElement('dd', '<span style="color:red">' . $version . '<br />Your PHP version is outdated. For security reasons, please go to your server management and set the current PHP version (> 7.0) for this host.</ span>'));
$dl->appendChild(new XMLElement('dd', '<span class="status-error">' . $version . '<br />Your PHP version is outdated. For security reasons, please go to your server management and set the current PHP version (> 7.0) for this host.</span>'));
}

$container->appendChild(new XMLElement('h4', __('Configuration')));
Expand Down