New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alerts): introduce duration attribute #525

Draft

dbonf wants to merge 2 commits into master from alerts-new-api-fields

Collaborator

dbonf commented Jun 20, 2024 •

edited

Loading

introduce the new duration_seconds attribute on v2 alerts that support it
deprecate trigger_after_minutes in favour of the new range_seconds (or duration_seconds in case of prometheus alerts) in order to avoid confusion with the new duration attribute
use new api fields to specify duration/range


          chore(alerts): use new duration fields for v1 alerts

1effafc

dbonf self-assigned this

dbonf force-pushed the alerts-new-api-fields branch from c65c5a8 to 79c16f1 Compare

June 20, 2024 11:38


          feat(alerts): introduce duration attribute

f0a6ce7

dbonf force-pushed the alerts-new-api-fields branch from 79c16f1 to f0a6ce7 Compare

June 20, 2024 11:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

michelevergnano Awaiting requested review from michelevergnano michelevergnano will be requested when the pull request is marked ready for review michelevergnano is a code owner

dkutsanov Awaiting requested review from dkutsanov dkutsanov will be requested when the pull request is marked ready for review dkutsanov is a code owner

antonio-cuomo Awaiting requested review from antonio-cuomo antonio-cuomo will be requested when the pull request is marked ready for review antonio-cuomo is a code owner

At least 1 approving review is required to merge this pull request.