Merge pull request #22 from tagconcierge/main

Main
tagconcierge · Jun 18, 2024 · 76756f7 · 76756f7
2 parents 09ec482 + b122d90
commit 76756f7
Show file tree

Hide file tree

Showing 6 changed files with 106 additions and 184 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,14 @@
 # Changelog
 
+## 1.2.3
+
+- fixed consent settings modal closing issue
+- improved consent settings opener event listener
+
+## 1.2.2
+
+- fixed appearance issues on mobile devices
+
 ## 1.2.1
 
 - changed the element on which the 'consent-banner.ready' event is called from document.body to window

diff --git a/README.md b/README.md
@@ -15,13 +15,13 @@
 
 First, include simple CSS for the banner in the `<head>` of the page:
 ```html
-<link rel="stylesheet" href="https://public-assets.tagconcierge.com/consent-banner/1.2.1/styles/light.css" />
+<link rel="stylesheet" href="https://public-assets.tagconcierge.com/consent-banner/1.2.3/styles/light.css" />
 ```
 
 Then in the footer you can include the actual JS:
 
 ```html
-<script src="https://public-assets.tagconcierge.com/consent-banner/1.2.1/cb.min.js" integrity="sha384-s3Z3P3jRWfGRi77peX7uOoW8f5AbSZ862qubQFqICB7mJ/mGtr1iGt/w986DleFP" crossorigin="anonymous"></script>
+<script src="https://public-assets.tagconcierge.com/consent-banner/1.2.3/cb.min.js" integrity="sha384-zXUdInIfEJI2FEImKEFc2cmja+Jn7TViSXzqt6OhABX0jMgz6Mctrc864uJaN5PX" crossorigin="anonymous"></script>
 <script>
     cookiesBannerJs(
         loadConsentState,
@@ -33,7 +33,7 @@ Then in the footer you can include the actual JS:
 
 Or if you want to load the library script asynchronously, you can use the following `consent-banner.ready` event listener, which will execute the function only when the library is loaded:
 ```html
-<script defer src="https://public-assets.tagconcierge.com/consent-banner/1.2.1/cb.min.js" integrity="sha384-s3Z3P3jRWfGRi77peX7uOoW8f5AbSZ862qubQFqICB7mJ/mGtr1iGt/w986DleFP" crossorigin="anonymous"></script>
+<script defer src="https://public-assets.tagconcierge.com/consent-banner/1.2.3/cb.min.js" integrity="sha384-zXUdInIfEJI2FEImKEFc2cmja+Jn7TViSXzqt6OhABX0jMgz6Mctrc864uJaN5PX" crossorigin="anonymous"></script>
 <script>
     window.addEventListener('consent-banner.ready', () => {
         cookiesBannerJs(

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@tagconcierge/consent-banner",
-  "version": "1.2.1",
+  "version": "1.2.3",
   "description": "A zero-dependency, lightweight (~3kB), consent platform agnostic, cookie banner for any website.",
   "main": "src/app.js",
   "keywords": ["consent banner", "consent mode", "gtm consent", "cookie banner"],

diff --git a/src/app.js b/src/app.js
@@ -229,7 +229,7 @@ function showSettings(main) {
 function hideSettings(main) {
   main.style.display = 'block';
   main.querySelector('#consent-banner-settings').style.display = 'none';
-  if ('true' !== main.getAttribute('data-wall')) {
+  if ('true' !== main.getAttribute('data-wall') || isConsentStateProvided(loadConsentState())) {
     hideWall(main);
   }
 }
@@ -283,8 +283,10 @@ function consentBannerJsMain(config) {
   addEventListener(settings.querySelector('[href="#close"]'), 'click', function(ev) {
     ev.preventDefault();
     hideSettings(main);
-    if (!isConsentStateProvided(existingConsentState)) {
+    if (!isConsentStateProvided(loadConsentState())) {
       showModal(main);
+    } else {
+      dispatchBodyEvent('hidden');
     }
   });
 
@@ -340,7 +342,7 @@ function consentBannerJsMain(config) {
     dispatchBodyEvent('hidden');
   });
 
-  addEventListener(body.querySelector('[href$="#consent-banner-settings"]'), 'click', function(ev) {
+  addEventListener(body.querySelectorAll('[href$="#consent-banner-settings"]'), 'click', function(ev) {
     ev.preventDefault();
     showSettings(main);
     hideModal(main);