Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont throw obtuse json parse error when rock returning an html page #60

Merged
merged 1 commit into from
Apr 16, 2024
Merged

dont throw obtuse json parse error when rock returning an html page #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/rock_rms/parse_oj.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,19 @@ class ParseOj < Faraday::Middleware
def on_complete(env)
if empty_body?(env[:body].strip)
env[:body] = nil
elsif html_body?(env[:body])
env[:body] = env[:body]
else
env[:body] = Oj.load(env[:body], mode: :compat)
end
end

private

def html_body?(body)
body.start_with?('<!DOCTYPE html>')
end

def empty_body?(body)
body.empty? && body == ''
end
Expand Down
Loading