Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βž• Add default values to roles #509

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bdsoha
Copy link
Contributor

@bdsoha bdsoha commented May 12, 2024

Proposed Changes

  • Add default values to roles to refrain from missing values in the all.yml file.
  • Allow modular use of roles when consumed as a collection.
  • Add metadata to all roles with documented arguments.

Checklist

  • Tested locally
  • Ran site.yml playbook
  • Ran reset.yml playbook
  • Did not add any unnecessary changes
  • Ran pre-commit install at least once before committing
  • πŸš€

@bdsoha bdsoha marked this pull request as draft May 13, 2024 04:04
@bdsoha
Copy link
Contributor Author

bdsoha commented May 21, 2024

@timothystewart6 It would be great to receive your input on whether or not such a PR is in the roadmap for this project.
If so, I will continue the work for all other roles.

@bdsoha
Copy link
Contributor Author

bdsoha commented Jun 3, 2024

@timothystewart6 Did you have a chance to look at this?

@timothystewart6
Copy link
Contributor

timothystewart6 commented Jun 3, 2024

@timothystewart6 Did you have a chance to look at this?

Hi! Yes, this sounds great as long as we don't break how it currently works. Unfortunately CI isn't working right now but I hope to have it working soon so that the tests will run!

Thanks!
Tim

@timothystewart6
Copy link
Contributor

Just let me know when this is ready!

@bdsoha
Copy link
Contributor Author

bdsoha commented Jun 9, 2024

No problem, I will change the PR status from draft to ready.

@bdsoha bdsoha marked this pull request as ready for review June 25, 2024 10:28
@bdsoha
Copy link
Contributor Author

bdsoha commented Jun 25, 2024

@timothystewart6 Ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants