-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hardening/23_admin_commands_over_ssh #24
Conversation
frbattid
commented
Jul 23, 2015
- Implements issue [cosmos-gui] Run administration commands remotely through SSH #23
- No unit tests available-
- (unofficial) e2e tests passed:
- Assignee @gtorodelvalle
@@ -2,15 +2,27 @@ | |||
"gui": { | |||
"port": 80 | |||
}, | |||
"clusters": { | |||
"storage": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if you have checked if the observed behaviour when these data is passed as "" is the desired one... :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be addressed in the following techdebt issue: #30
LGTM but a couple of minor comments included regarding passing configuration parameters as blank ;) |
…er_ssh hardening/23_admin_commands_over_ssh