hardening/77_tls_support #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frbattid
commented
Sep 28, 2015
frbattid
commented
- Implements issue [cosmos-gui] Add TLS support #77
- No unit tests nor e2e tests are required.
- Assignee @gtorodelvalle
| @@ -49,6 +51,10 @@ var scEndpoint = config.clusters.storage.endpoint; | |||
| var ccPrivKey = config.clusters.computing.private_key; | |||
| var ccUser = config.clusters.computing.user; | |||
| var ccEndpoint = config.clusters.computing.endpoint; | |||
| var httpsOptions = { | |||
| key: fs.readFileSync(config.private_ley_filekey), | |||
There was a problem hiding this comment.
I think there's a typo here: private_ley_filekey -> private_key_file :) Apart from this, I may have asked this before :p but have you confirmed that this works if config.private_ley_filekey and certificate_file are blank ('') as in the default configuration? :)
There was a problem hiding this comment.
Yes, there is a typo, I'll fix it.
Regarding the parameters check, I have a tech debt issue about it... that I think I will implement in the second release :)
|
LGTM and merging! :) Thanks @frbattid |
gtorodelvalle
added a commit
that referenced
this pull request
Sep 29, 2015
hardening/77_tls_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.