Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
@fgalan
fgalan authored Jan 19, 2023
1 parent 1d44ab5 commit bc4daaa
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 12 deletions.
4 changes: 0 additions & 4 deletions docker/cygnus-common/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ ENV MVN_TGZ "apache-maven-${MVN_VER}-bin.tar.gz"
ENV MVN_URL "http://www.eu.apache.org/dist/maven/maven-3/${MVN_VER}/binaries/${MVN_TGZ}"
ENV MVN_HOME "/opt/apache-maven"

# FIXME: appart from upgrading Flume version in PR #2212, this Dockerfile has not been actually
# tested. It should be reviews and aligned with the one in cygnus-ngsi (for instance, we shouldn't need
# to directly download the flume package, as it should be installed through mvn based in the pom.xml
# configuration)
ENV FLUME_VER "1.11.0"
ENV FLUME_TGZ "apache-flume-${FLUME_VER}-bin.tar.gz"
ENV FLUME_URL "http://archive.apache.org/dist/flume/${FLUME_VER}/${FLUME_TGZ}"
Expand Down
4 changes: 0 additions & 4 deletions docker/cygnus-ngsi-ld/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -267,10 +267,6 @@ ENV CYGNUS_ARCGIS_BATCH_TTL ""
ENV MVN_VER "3.5.4"
ENV MVN_HOME "/opt/apache-maven"

# FIXME: appart from upgrading Flume version in PR #2212, this Dockerfile has not been actually
# tested. It should be reviews and aligned with the one in cygnus-ngsi (for instance, we shouldn't need
# to directly download the flume package, as it should be installed through mvn based in the pom.xml
# configuration)
ENV FLUME_VER "1.11.0"
ENV FLUME_HOME "/opt/apache-flume"

Expand Down
4 changes: 0 additions & 4 deletions docker/cygnus-twitter/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ ENV MVN_TGZ "apache-maven-${MVN_VER}-bin.tar.gz"
ENV MVN_URL "http://www.eu.apache.org/dist/maven/maven-3/${MVN_VER}/binaries/${MVN_TGZ}"
ENV MVN_HOME "/opt/apache-maven"

# FIXME: appart from upgrading Flume version in PR #2212, this Dockerfile has not been actually
# tested. It should be reviews and aligned with the one in cygnus-ngsi (for instance, we shouldn't need
# to directly download the flume package, as it should be installed through mvn based in the pom.xml
# configuration)
ENV FLUME_VER "1.11.0"
ENV FLUME_TGZ "apache-flume-${FLUME_VER}-bin.tar.gz"
ENV FLUME_URL "http://archive.apache.org/dist/flume/${FLUME_VER}/${FLUME_TGZ}"
Expand Down

0 comments on commit bc4daaa

Please sign in to comment.