Merge pull request #2306 from telefonicaid/task/add_pk_error_log_table

add Primary Key to error log table
telefonicaid · Sep 27, 2023 · bd11469 · bd11469
2 parents f45868f + 41d4729
commit bd11469
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE
@@ -1,5 +1,6 @@
-- [cygnus-common] Upgrade mysql-java-connector dependency from 8.0.28 to 8.0.33
+- [cygnus-common] [SQL] Add Primary Key on Timestamp to Error Log table (#2302)
 - [cygnus-common] Upgrade gson dependency from 2.6.2 to 2.10.1
+- [cygnus-common] Upgrade mysql-java-connector dependency from 8.0.28 to 8.0.33
 - [cygnus-ngsi][cygnus-common] upgrade mockito dep from 1.9.5 to 5.5.0
 - [cygnus-ngsi] Fix runtime error: check access aggregator size (#2293)
 - [cygnus-ngsi] Switch log level to CYGNUS_LOG_LEVEL env var if was provided to docker (#2286)

diff --git a/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/sql/SQLBackendImpl.java b/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/sql/SQLBackendImpl.java
@@ -583,13 +583,15 @@ public void createErrorTable(String dataBase, String schema)
             errorTableName = schema + "." + dataBase + DEFAULT_ERROR_TABLE_SUFFIX;
         }
         String typedFieldNames = "(" +
-                "timestamp TIMESTAMP" +
+                "timestamp TIMESTAMP NOT NULL" +
                 ", error text" +
-                ", query text)";
+                ", query text" +
+            ", CONSTRAINT PK_ErrorLog PRIMARY KEY (timestamp) )";
         String typedFieldNamesOracle = "(" +
-                "timestamp TIMESTAMP" +
+                "timestamp TIMESTAMP NOT NULL" +
                 ", error clob" +
-                ", query clob)";
+                ", query clob" +
+            ", CONSTRAINT PK_ErrorLog PRIMARY KEY (timestamp) )";
 
         Statement stmt = null;
         // get a connection to the given destination