Merge pull request #2414 from telefonicaid/fix/check_server_features_…

…before_access check serverFeatures before access it
telefonicaid · Sep 24, 2024 · f1134af · f1134af
2 parents 7b4b014 + e08fc16
commit f1134af
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 12 deletions.
diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE
@@ -0,0 +1 @@
+- [cygnus-ngsi][arcgis] Fix CygnusRuntimeError due to Cannot invoke "java.util.List.size()" because "serverFeatures" is null (#2413)
diff --git a/...src/main/java/com/telefonica/iot/cygnus/backends/arcgis/restutils/ArcgisFeatureTable.java b/...src/main/java/com/telefonica/iot/cygnus/backends/arcgis/restutils/ArcgisFeatureTable.java
@@ -387,19 +387,21 @@ protected void splitFeatureListIfExists(List<Feature> featureArray,
             }
 
             int i = 0;
-            while (!found && i < serverFeatures.size()) {
-                Feature serverFeature = serverFeatures.get(i);
-                String serverFeatureId = null;
-                if ( serverFeature.getAttributes().containsKey(uniqueField)) {
-                    serverFeatureId = serverFeature.getAttributes().get(uniqueField).toString();
-                }
-                if (featureId.equalsIgnoreCase(serverFeatureId)) {
-                    found = true;
-                    Integer oid = serverFeature.getObjectId();
-                    feature.setObjectId(oid);
-                    existentFeatures.add(feature);
+            if (serverFeatures != null) {
+                while (!found && i < serverFeatures.size()) {
+                    Feature serverFeature = serverFeatures.get(i);
+                    String serverFeatureId = null;
+                    if ( serverFeature.getAttributes().containsKey(uniqueField)) {
+                        serverFeatureId = serverFeature.getAttributes().get(uniqueField).toString();
+                    }
+                    if (featureId.equalsIgnoreCase(serverFeatureId)) {
+                        found = true;
+                        Integer oid = serverFeature.getObjectId();
+                        feature.setObjectId(oid);
+                        existentFeatures.add(feature);
+                    }
+                    i++;
                 }
-                i++;
             }
 
             if (!found) {