Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ngsi_arcgis_featuretable_sink.md #2327

Merged
merged 24 commits into from
Dec 13, 2023
Merged

Conversation

danielvillalbamota
Copy link
Collaborator

Add description to limitations in Arcgis sink

@danielvillalbamota danielvillalbamota changed the title [WIP] Update ngsi_arcgis_featuretable_sink.md Update ngsi_arcgis_featuretable_sink.md Dec 4, 2023
Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -133,7 +135,6 @@ A configuration example could be:
cygnus-ngsi.sinks.arcgis-sink.type = com.telefonica.iot.cygnus.sinks.NGSIArcgisFeatureTableSink
cygnus-ngsi.sinks.arcgis-sink.channel = arcgis-channel
cygnus-ngsi.sinks.arcgis-sink.enable_name_mappings = true
cygnus-ngsi.sinks.arcgis-sink.enable_name_mappings = false
Copy link
Collaborator

@manucarrace manucarrace Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated line in example. NTC

Copy link
Collaborator

@manucarrace manucarrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


Feature table url: https://arcgis.com/{hash}/arcgis/rest/services/vehicles/4wheels
Table's unique field: car

[Top](#top)

#### Using Context Broker custom notifications
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be included in ToC above? It seem that four level sections (i.e. ####) are included in ToC, if I have understood correctly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title level was wrong, fixed in deb80da

service-path = /4wheels
entity-type = van

For example, if the Feature table for "van" is `https://arcgis.com/{hash}/arcgis/rest/services/vehicles/van`, the custom notif could be:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to include the full JSON of the subscription, including the subject object, so it can be seen how `"type": "van" is used in this case).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, review the whole document to change:

  • van -> Van
  • car -> Car

and any other type so we use the current cannonical way of naming entity types (i.e. with first capital letter).

Comment on lines 108 to 111
###### result

Feature table url: https://arcgis.com/{hash}/arcgis/rest/services/vehicles/van
Table's unique field: car
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the result of the second example? Why don't include the result of the first example?

It's a bit weird... maybe we should talk by skype.

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 3a1b572 into master Dec 13, 2023
5 checks passed
@fgalan fgalan deleted the danielvillalbamota-patch-1 branch December 13, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants