Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/check get lastdata before remove #2355

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Mar 7, 2024

time=2024-03-07T10:32:00.371Z | lvl=ERROR | corr=776e343e-8e3e-4e55-99ca-67939e592c99; cbnotif=15 | trans=5bd491ef-ffc2-4d47-8141-368c227d7138 | srv=N/A | subsrv=N/A | comp=cygnus-ngsi | op=processNewBatches | msg=com.telefonica.iot.cygnus.sinks.NGSISink[619] : Cannot invoke "java.util.ArrayList.remove(int)" because the return value of "java.util.LinkedHashMap.get(Object)" is null Sink: postgis-sink Destination: smartcity_/_ValidationAsset Stack trace: [com.telefonica.iot.cygnus.aggregation.NGSIGenericColumnAggregator.aggregate(NGSIGenericColumnAggregator.java:247), com.telefonica.iot.cygnus.sinks.NGSIPostgisSink.persistBatch(NGSIPostgisSink.java:390), com.telefonica.iot.cygnus.sinks.NGSISink.processNewBatches(NGSISink.java:597), com.telefonica.iot.cygnus.sinks.NGSISink.process(NGSISink.java:372), org.apache.flume.sink.DefaultSinkProcessor.process(DefaultSinkProcessor.java:39), org.apache.flume.SinkRunner$PollingRunner.run(SinkRunner.java:145), java.base/java.lang.Thread.run(Thread.java:840)]

Maybe related with recent jdk update (from 11 to 17)

@AlvaroVega AlvaroVega marked this pull request as ready for review March 7, 2024 15:17
@AlvaroVega AlvaroVega requested a review from fgalan March 8, 2024 08:35
@AlvaroVega
Copy link
Member Author

AlvaroVega commented Mar 8, 2024

This PR fixes cases when a batch of events with multiple entityCreation and entityUpdate arrives and some of then are not created.

Copy link
Collaborator

@danielvillalbamota danielvillalbamota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 93f11cb into master Mar 8, 2024
7 checks passed
@fgalan fgalan deleted the fix/check_get_lastdata_before_remove branch March 8, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants