Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mongo sink adding ssl options #2386

Merged
merged 15 commits into from
Jun 19, 2024
Merged

update mongo sink adding ssl options #2386

merged 15 commits into from
Jun 19, 2024

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Jun 18, 2024 •
edited
Loading

@AlvaroVega AlvaroVega marked this pull request as ready for review June 19, 2024 07:16
@AlvaroVega AlvaroVega changed the title Task/add ssl context update mongo sink adding ssl options Jun 19, 2024
@AlvaroVega AlvaroVega mentioned this pull request Jun 19, 2024
Closed
1 task
@AlvaroVega AlvaroVega requested a review from mrutid June 19, 2024 08:21
mrutid
mrutid reviewed Jun 19, 2024
View reviewed changes
cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/mongo/MongoBackendImpl.java Outdated
}
} else {
client = new MongoClient(servers);
MongoClientOptions options = MongoClientOptions.builder()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this branch seems extrange, at least "structurally" with respect the previous ones. Could be?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in d0d92ce

mrutid
mrutid approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@mrutid mrutid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrutid mrutid merged commit d4b30c8 into master Jun 19, 2024
8 checks passed
@mrutid mrutid deleted the task/add_ssl_context branch June 19, 2024 09:56
@fgalan
Copy link
Member

fgalan commented Jun 26, 2024

Instead of adding individual fields to configure MongoDB, a more scalable soluction would be to removing them all and replace for a mongo_uri parameter.

Similar to what has been done recently in Orion Context Broker

This version removes -dbhost, -rplSet, -dbTimeout, -dbuser, -dbAuthMech, -dbAuthDb, -dbSSL and -dbDisableRetryWrites CLI parameters along with associated env vars (deprecated in 3.12.0 version), so you have to use -dbURI (env var ORION_MONGO_URI) instead. Have a look to this documentation section if you need help to migrate the configuration.

@AlvaroVega
Copy link
Member Author

Instead of adding individual fields to configure MongoDB, a more scalable soluction would be to removing them all and replace for a mongo_uri parameter.

Similar to what has been done recently in Orion Context Broker

This version removes -dbhost, -rplSet, -dbTimeout, -dbuser, -dbAuthMech, -dbAuthDb, -dbSSL and -dbDisableRetryWrites CLI parameters along with associated env vars (deprecated in 3.12.0 version), so you have to use -dbURI (env var ORION_MONGO_URI) instead. Have a look to this documentation section if you need help to migrate the configuration.

Yeah! It would be nice a great feature, replace MongoClientOptions to MongoClientUri

This was referenced Jun 26, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrutid mrutid mrutid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvaroVega @fgalan @mrutid