Skip to content

Commit

Permalink
FIX typos
Browse files Browse the repository at this point in the history
  • Loading branch information
fgalan committed Nov 8, 2023
1 parent b54284e commit f2818ab
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions src/lib/parse/CompoundValueNode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ std::string CompoundValueNode::check(const std::string& path)
*/
bool CompoundValueNode::equal(const orion::BSONElement& be)
{
// Note object cannot be declared inside switch block
// Note objects cannot be declared inside switch block
std::vector<orion::BSONElement> ba;
orion::BSONObj bo;

Expand All @@ -540,7 +540,8 @@ bool CompoundValueNode::equal(const orion::BSONElement& be)
return (be.type() == orion::String) && (stringValue == be.String());

case orion::ValueTypeNumber:
// FIXME PR: unurure if this is going to work with all the Number types (int32/int64/double)
// FIXME P2: according to regression tests, this seems to work with all number types (int32/int64/double)
// However, let's keep an eye on this in the case some day it fails...
return (be.type() == orion::NumberDouble && numberValue == be.Number());

case orion::ValueTypeBoolean:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ accumulatorStart --pretty-print
# 06. Update E-A entity with same JSON array in metadata (notification)
# 07. Update E-A entity with different JSON array in metadata (notification)
# 08. Update E-A entity with same string in metadata (notification)
# 09. Dump accumulator, see 5 notifications
# 09. Dump accumulator, see 7 notifications
#

echo "01. Create subscription covering E-A"
Expand Down

0 comments on commit f2818ab

Please sign in to comment.