ADD MQTT retain feature #4412
Merged
ADD MQTT retain feature #4412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
commented
Aug 30, 2023
Comment on lines
+286
to
+287
| - **topic**: MQTT topic (only in MQTT notifications) | ||
| - **qos**: MQTT QoS value (only in MQTT notifications) |
There was a problem hiding this comment.
Taking into account this at src/lib/mongoBackend/dbConstants.h
#define CSUB_MQTTTOPIC "topic"
#define CSUB_MQTTQOS "qos"
It seems mqttQoS and mqttTopic was a typo.
NTC (informative)
|
Seems those tests need to be updated adding retain field @@ -53,13 +53,13 @@
[853](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:854)
05. GET subs checking user1 but password offuscated
[854](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:855)
===================================================
[855](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:856)
HTTP/1.1 200 OK
[856](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:857)
-Date: REGEX(.*)
[857](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:858)
-Fiware-Correlator: REGEX([0-9a-f\-]{36})
[858](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:859)
+Date: Wed, 30 Aug 2023 13:36:33 GMT
[859](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:860)
+Fiware-Correlator: 3bd9e520-473a-11ee-836e-6045bde3459b
[860](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:861)
Content-Type: application/json
[861](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:862)
-Content-Length: 351
[862](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:863)
+Content-Length: 366
[863](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:864)
[864](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:865)
{
[865](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:866)
- "id": "REGEX([0-9a-f\-]{24})",
[866](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:867)
+ "id": "64ef45e19cdd8ac0b40762ea",
[867](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:868)
"notification": {
[868](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:869)
"attrs": [],
[869](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:870)
"attrsFormat": "normalized",
[870](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:871)
@@ -67,6 +67,7 @@
[871](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:872)
"mqttCustom": {
[872](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:873)
"passwd": "*****",
[873](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:874)
"qos": 0,
[874](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:875)
+ "retain": false,
[875](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:876)
"topic": "/orion",
[876](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:877)
"url": "mqtt://localhost:1883",
[877](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:878)
"user": "user1"
[878](https://github.com/telefonicaid/fiware-orion/actions/runs/6025542138/job/16346471518?pr=4412#step:4:879)
@@ -98,21 +99,21 @@ |
|
@fisuda this PR does some modifications to the English documentation. It would be great if you could sync the Japanese translation in a PR (using either feature/4388_mqtt_retain or master as base branch, as you prefer), please. Thanks in advance! |
|
I sent the PR #4413 to the feature/4388_mqtt_retain branch. |
(JP) Add doc about MQTT retain feature (#4412)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4388
or manual testing?) - 19f3d2c