Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX improve documentation about building Orion #4426

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Sep 11, 2023

As a complement of recent works (PRs #4422, #4423 and #4425) I think it would be a good idea to provide the docker build commands to build Orion in Ubuntu and Alpine in users documentation.

@fisuda what do you think? Please provide feedback on this PR. If you think is ok, it would be great if you could do a PR using hardening/doc-building branch to sync translation in the Japanese documents, please.

@fisuda
Copy link
Contributor

fisuda commented Sep 11, 2023

LGTM.
I sent the PR #4427 to update Japanese documentation.
Thanks.

(JP) FIX improve documentation about building Orion (#4426)
Copy link
Collaborator

@mapedraza mapedraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapedraza mapedraza merged commit 4953012 into master Sep 11, 2023
11 of 12 checks passed
@mapedraza mapedraza deleted the hardening/doc-building branch September 11, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants