Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX false positive in log deprecation logic when entity name (or other literal) includes the token v1 #4455

Merged
merged 1 commit into from
Dec 19, 2023
Merged

FIX false positive in log deprecation logic when entity name (or other literal) includes the token v1 #4455

merged 1 commit into from
Dec 19, 2023

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Dec 19, 2023 •
edited
Loading

Issue #4454

@fgalan fgalan mentioned this pull request Dec 19, 2023
Closed
AlvaroVega
AlvaroVega approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroVega AlvaroVega merged commit cacc076 into master Dec 19, 2023
12 checks passed
@AlvaroVega AlvaroVega deleted the hardening/4454_false_positive_in_log_deprecation_logic branch December 19, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvaroVega AlvaroVega AlvaroVega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgalan @AlvaroVega