-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Valgrind regression for 3.11.0 + fixes #4493
Conversation
This reverts commit 59bdb40.
The only test that fails seems to be a glitch, as local execution works fine:
Rerunning tests... |
It has failed same test in the second attemp
I have also checked with the CI image and it works:
Edit:* running also without
Running test third time... |
Another run in local with CI image with the failing test and some previous ones:
|
In github attemp number 3:
|
In github attemp 4:
This is getting weird :) |
Attemp 5 finally worked. That shows the fail was a glitch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR will be closed without merge after use.At the end some fix was included, so the PR was actually merged.Similar to PR #4370