Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX deprecated old db CLI #4505

Merged
merged 4 commits into from
Feb 26, 2024
Merged

FIX deprecated old db CLI #4505

merged 4 commits into from
Feb 26, 2024

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Feb 7, 2024

Support both old db CLIs and -dbURI may be problematic (see issue #4496) so better to deprecated the former (and eventually remove them).

Copy link
Collaborator

@mapedraza mapedraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan
Copy link
Member Author

fgalan commented Feb 22, 2024

@fisuda this PR modifies part of the English documentation. It would be great if you could do a PR using hardening/deprecate_old_db_cli as base branch, so we can integrate the Japanese changes into this PR and merge all them at once, please.

@fisuda
Copy link
Contributor

fisuda commented Feb 23, 2024

I sent the PR #4518. Thanks.

(JP) FIX deprecated old db CLI (#4505)
@mapedraza mapedraza merged commit cbc6238 into master Feb 26, 2024
12 checks passed
@mapedraza mapedraza deleted the hardening/deprecate_old_db_cli branch February 26, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants