Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in Orion DB consistency script #4535

Merged
merged 7 commits into from
Apr 10, 2024
Merged

Improvements in Orion DB consistency script #4535

merged 7 commits into from
Apr 10, 2024

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Apr 10, 2024

  • Renaing to a more proper name (oriondb_consistency.py, as now we check also csubs colections, not only entities collection)
  • Entity rules renamed xx -> Exx
  • Implement rules S90 to check usages of legacy notification format
  • Implement autofix for rule S90
  • Refactor and fixes

danielvillalbamota
danielvillalbamota approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@danielvillalbamota danielvillalbamota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielvillalbamota danielvillalbamota merged commit 0c4107e into master Apr 10, 2024
12 checks passed
@danielvillalbamota danielvillalbamota deleted the check-legacy-subs-in-db branch April 10, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielvillalbamota danielvillalbamota danielvillalbamota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgalan @danielvillalbamota