Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD evalPriority feature #4590

Merged
merged 12 commits into from
Jul 3, 2024
Merged

ADD evalPriority feature #4590

merged 12 commits into from
Jul 3, 2024

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Jul 2, 2024 •
edited
Loading

Issue #4556

  • Re-align .test
  • New test: evalPriority fails + CRUD
  • Fix FIXME PR marks
  • Doc
  • CNR

@mapedraza
Copy link
Collaborator

May a test should implement attributes ordered by priority in a different way than alphabetically

@fgalan fgalan mentioned this pull request Jul 2, 2024
Closed
@fgalan
Copy link
Member Author

fgalan commented Jul 3, 2024

May a test should implement attributes ordered by priority in a different way than alphabetically

Done in 3eed5ca

@fgalan fgalan changed the title [WIP] ADD evalPriority feature ADD evalPriority feature Jul 3, 2024
fgalan
fgalan commented Jul 3, 2024
View reviewed changes
src/lib/common/JsonHelper.cpp
Comment on lines 428 to 436
/* ****************************************************************************
*
* JsonVectorHelper::str -
*/
std::string JsonVectorHelper::str()
std::string JsonVectorHelper::str(void)
{
// This check allows to call str() several times (needed when this is used in ExprContext)
if (!closed)
{
ss += ']';
closed = true;
}
ss += ']';
return ss;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced in 4.0.0, but it seems is not actually needed.

Going back to 3.12.0 version of this code.

NTC (informative)

fgalan
fgalan commented Jul 3, 2024
View reviewed changes
doc/manuals/orion-api.md Outdated Show resolved Hide resolved
fgalan
fgalan commented Jul 3, 2024
View reviewed changes
doc/manuals/orion-api.md Outdated Show resolved Hide resolved
@fgalan fgalan requested a review from mapedraza July 3, 2024 10:36
mapedraza
mapedraza reviewed Jul 3, 2024
View reviewed changes
doc/manuals/orion-api.md Outdated Show resolved Hide resolved
mapedraza
mapedraza approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@mapedraza mapedraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapedraza mapedraza merged commit e496759 into master Jul 3, 2024
12 checks passed
@mapedraza mapedraza deleted the feature/4556_eval_priority_in_expressions branch July 3, 2024 12:03
@fgalan
Copy link
Member Author

fgalan commented Jul 3, 2024

@fisuda this PR does some additions to English documnentation. It would be great if you could sync the Japanese translation in a PR, please. Thanks in advance!

fisuda added a commit to fisuda/fiware-orion that referenced this pull request Jul 4, 2024
@fisuda
(JP) ADD doc about evalPriority feature (telefonicaid#4590)
bdb93e8
@fisuda
Copy link
Contributor

fisuda commented Jul 4, 2024

I sent the PR #4591. Thanks.

fgalan added a commit that referenced this pull request Jul 4, 2024
@fgalan
Merge pull request #4591 from fisuda/patch
8c24790 
(JP) ADD doc about evalPriority feature (#4590)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapedraza mapedraza mapedraza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgalan @mapedraza @fisuda