Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] REMOVE NGSIv1 dead code #4603

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
78e98b3
REMOVE apiVersion enum
fgalan Aug 5, 2024
e8c5644
REMOVE ngsiv1Autocast
fgalan Aug 6, 2024
d2cf789
REMOVE checkIdv1
fgalan Aug 6, 2024
147dadc
FIX broken unit test
fgalan Aug 6, 2024
ce12776
REMOVE strings2numbers in valueBson() and compoundValueBson()
fgalan Aug 6, 2024
00b6c26
REMOVE autocast
fgalan Aug 6, 2024
9880e76
REMOVE dead code in serviceRoutines and mongoBackend libs so orionRes…
fgalan Aug 7, 2024
44629c8
FIX change from std::string to void in return of postQueryContext() a…
fgalan Aug 8, 2024
07113ae
REMOVE toJsonV1 from in OrionError class
fgalan Aug 8, 2024
839f795
REMOVE restErrorReplyGet() function in favour of OrionError usage
fgalan Aug 8, 2024
7fc7db4
REMOVE not used items in HttpStatusCode and OrionError::shrinkError()…
fgalan Aug 8, 2024
8c1b097
FIX remove legacyForwarding true in test that does not need it
fgalan Aug 9, 2024
1d89e17
REMOVE jsonParse library including needed adaptations in other parts …
fgalan Aug 8, 2024
0712449
FIX cleanup of the previous commit
fgalan Aug 9, 2024
e138a43
REMOVE convenience library
fgalan Aug 9, 2024
33f4ba6
FIX cleanup dead code in unittest (but still not working)
fgalan Aug 9, 2024
55f97a0
REMOVE toNgsiv2Subscription() methods
fgalan Aug 9, 2024
b4cee10
REMOVE MongoCommonRegister, UpdateContextSubscriptionRequest, UpdateC…
fgalan Aug 12, 2024
590ffe0
FIX broken unit tests
fgalan Aug 12, 2024
be3bd64
FIX compliance check
fgalan Aug 12, 2024
fab25cb
REMOVE Duration, Originator, Reference, RegistrationId, SubscribeErro…
fgalan Aug 12, 2024
eff5984
REMOVE jsonV1ParseTime stuff and unneded items in ParseData type
fgalan Aug 12, 2024
383e668
REMOVE NotifyConditionVector, NotifyCondition, ConditionValueList, Re…
fgalan Aug 12, 2024
80e1a56
FIX simplify ContextElementResponse::ContextElementResponse()
fgalan Aug 12, 2024
98ee614
REMOVE processAreaScope() and orion::Circle
fgalan Aug 13, 2024
181fcc4
REMOVE parserScope module
fgalan Aug 13, 2024
c0e1a25
Revert "FIX simplify ContextElementResponse::ContextElementResponse()"
fgalan Aug 13, 2024
b984341
REMOVE Restriction class
fgalan Aug 13, 2024
f2476c9
RENAME setStatusCodeAndSmartRender() to setSCAndRender()
fgalan Aug 13, 2024
b7cdb87
REMOVE orion::Circle
fgalan Aug 13, 2024
e51a3a3
REMOVE dead code
fgalan Aug 14, 2024
0b73778
FIX little fix in ftest and compliance check
fgalan Aug 22, 2024
bbe9061
Merge branch 'master' into remove/ngsiv1-deadcode
fgalan Aug 22, 2024
ec713b8
Merge branch 'master' into remove/ngsiv1-deadcode
fgalan Aug 23, 2024
b23defb
FIX remove NGSIv1 leftovers
fgalan Aug 26, 2024
24b7753
Merge branch 'master' into remove/ngsiv1-deadcode
fgalan Aug 27, 2024
4e83aef
REMOVE some ngsi9 and ngsi10 text leftovers
fgalan Aug 27, 2024
bb265be
FIX minor
fgalan Aug 28, 2024
77a700d
FIX use Registration classes in registrationsQuery() and related code
fgalan Aug 28, 2024
24a4ba1
FIX registrationsQuery() implementation (some ftest may still fail)
fgalan Aug 28, 2024
96ecbe6
FIX avoid double-loging in fowarding legacy deprecation logs
fgalan Aug 29, 2024
e8c9f1a
FIX errors in forwarding logic introduce in recent commits (some ftes…
fgalan Aug 29, 2024
03da017
FIX errors in forwarding logic introduce in recent commits (all ftest…
fgalan Aug 29, 2024
2545a5f
REMOVE unneded ContextRegistration classes (now Registration class is…
fgalan Aug 29, 2024
89b4593
REMOVE ProvidingApplication class (in favour of ngsiv2::Provider class)
fgalan Aug 30, 2024
3e0ac73
FIX unit tests
fgalan Aug 30, 2024
0410d5c
FIX several FIXME PR cases
fgalan Aug 30, 2024
f3ebe3d
FIX unittest
fgalan Aug 30, 2024
469ac63
FIX refactoring in unittest
fgalan Aug 30, 2024
5ae4133
Merge branch 'master' into remove/ngsiv1-deadcode
fgalan Aug 30, 2024
a7e594c
REMOVE Attribute class
fgalan Aug 30, 2024
97fc17c
FIX Merge EntID logic into EntityId class (to remove EntID in a soon …
fgalan Sep 2, 2024
f37e150
REMOVE unused field in areas.h/cpp
fgalan Sep 4, 2024
c3fe132
REMOVE redundant EntID class
fgalan Sep 4, 2024
b50c413
REMOVE redundant Entities class (in favour of EntityVector)
fgalan Sep 5, 2024
e5642b8
REMOVE unneded forward declaration
fgalan Sep 6, 2024
45058b6
REMOVE buildGeneralErrorResponse (tentative)
fgalan Sep 6, 2024
7db81db
FIX cleanup comments
fgalan Sep 6, 2024
4125c4d
REMOVE StatusCode class (in favour of OrionError) (wip)
fgalan Sep 6, 2024
e43723c
Merge branch 'master' into remove/ngsiv1-deadcode
fgalan Sep 12, 2024
9128579
Merge branch 'master' into remove/ngsiv1-deadcode
fgalan Sep 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions CHANGES_NEXT_RELEASE
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix: registrations with more than one contextRegistration element (not possible in NGSIv2) are logged as Runtime Errors
11 changes: 3 additions & 8 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -187,20 +187,18 @@ ENDIF()

SET (ORION_LIBS
common
rest # verbName(Verb) from [email protected]; jsonRequestTreat from [email protected];
serviceRoutinesV2
serviceRoutines
ngsiNotify
rest # verbName(Verb) from [email protected]; jsonRequestTreat from [email protected];
jsonParse
jsonParseV2
rest # this is repeated for linking str2Verb from [email protected];
# verbName(Verb) from [email protected]
convenience
ngsi9
mongoBackend
ngsi10
ngsi
cache
mongoBackend
mongoBackend # repeated (probably due to some circular dependency between mongoBackend and ngsi)
mongoDriver
parse
apiTypesV2
Expand Down Expand Up @@ -325,13 +323,10 @@ if (error EQUAL 0)
ADD_SUBDIRECTORY(src/lib/ngsi)
ADD_SUBDIRECTORY(src/lib/serviceRoutines)
ADD_SUBDIRECTORY(src/lib/serviceRoutinesV2)
ADD_SUBDIRECTORY(src/lib/convenience)
ADD_SUBDIRECTORY(src/lib/ngsi9)
ADD_SUBDIRECTORY(src/lib/ngsi10)
ADD_SUBDIRECTORY(src/lib/ngsiNotify)
ADD_SUBDIRECTORY(src/lib/apiTypesV2)
ADD_SUBDIRECTORY(src/lib/parse)
ADD_SUBDIRECTORY(src/lib/jsonParse)
ADD_SUBDIRECTORY(src/lib/jsonParseV2)
ADD_SUBDIRECTORY(src/lib/rest)
ADD_SUBDIRECTORY(src/lib/mongoBackend)
Expand Down
6 changes: 0 additions & 6 deletions doc/manuals.jp/admin/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,6 @@ broker はデフォルトでバックグラウンドで実行されるため、
- **-logLineMaxSize** : ログ行の最大長 (超過すると、Orion は `LINE TOO LONG` をログ・トレースとして出力します)。最小許容値:100バイト。デフォルト値:32キロバイト。Orion の起動後に [log admin REST API](management_api.md#log-configs-and-trace-levels) の `lineMaxSize` フィールドで変更できます
- **-logInfoPayloadMaxSize** : リクエストおよび/またはレスポンス・ペイロードを出力する INFO レベルのログ・トレースの場合、これはそれらのペイロードに許可される最大サイズです。ペイロード・サイズがこの設定より大きい場合、最初の `-logInfoPayloadMaxSize` バイトのみが含まれます (そして、`(...)` の形式の省略記号がトレースに表示されます)。デフォルト値:5キロバイト。Orion の起動後に [log admin REST API](management_api.md#log-configs-and-trace-levels) で `infoPayloadMaxSize` フィールドを使用して変更できます。
- **-disableMetrics** : 'metrics' 機能をオフにします。メトリックの収集は、システムコールやセマフォが関与するため、少しコストがかかります。メトリックオーバーヘッドなしで broker を起動するには、このパラメータを使用します
- **-disableNgsiv1** : NGSIv1 操作をオフにします。 API エンドポイントのみが無効になることに注意してください。
[`"attrsFormat": "legacy"`](../orion-api.md#subscriptionnotification) を使用する通知や、
[`"legacyForwarding": true`](../orion-api.md#registrationprovider) を使用するレジストレーションに対応するリクエスト転送は機能します
- **-insecureNotif** : 既知の CA 証明書で認証できないピアへの HTTPS 通知を許可する。これは、curl コマンドのパラメータ `-k` または `--insecureparameteres` に似ています
- **-mqttMaxAge** : 未使用の MQTT 接続が保持される最大時間 (分単位)。デフォルト値: 60
- **-logDeprecate** : 非推奨の使用法を警告として記録します。詳細については、[ドキュメントのこのセクション](../deprecated.md#log-deprecation-warnings) を参照してください。デフォルトは false です。これは、Orion の起動後に [log admin REST API](management_api.md#log-configs-and-trace-levels) を使用して `deprecated` フィールドを使用して変更できます
Expand Down Expand Up @@ -160,14 +157,11 @@ Orion は、環境変数を使用した引数の受け渡しをサポートし
| ORION_STAT_NOTIF_QUEUE | statNotifQueue |
| ORION_LOG_SUMMARY_PERIOD | logSummary |
| ORION_RELOG_ALARMS | relogAlarms |
| ORION_CHECK_ID_V1 | strictNgsiv1Ids |
| ORION_DISABLE_CUSTOM_NOTIF | disableCustomNotifications |
| ORION_DISABLE_FILE_LOG | disableFileLog |
| ORION_LOG_FOR_HUMANS | logForHumans |
| ORION_LOG_LINE_MAX_SIZE | logLineMaxSize |
| ORION_LOG_INFO_PAYLOAD_MAX_SIZE | logInfoPayloadMaxSize |
| ORION_DISABLE_METRICS | disableMetrics |
| ORION_DISABLE_NGSIV1 | disableNgsiv1 |
| ORION_INSECURE_NOTIF | insecureNotif |
| ORION_NGSIV1_AUTOCAST | ngsiv1Autocast |
| ORION_MQTT_MAX_AGE | mqttMaxAge |
2 changes: 0 additions & 2 deletions doc/manuals.jp/admin/logs.md
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,6 @@ time=2020-10-26T15:06:14.642Z | lvl=INFO | corr=c4a3192e-179c-11eb-ac8f-000c29df
```
time=2024-01-11T13:57:13.537Z | lvl=WARN | corr=527378d8-b089-11ee-875d-080027cd35f1 | trans=1704981432-655-00000000006 | from=127.0.0.1 | srv=s1 | subsrv=/A | comp=Orion | op=mongoRegistrationCreate.cpp[235]:mongoRegistrationCreate | msg=Deprecated usage of legacyForwarding mode in registration creation (regId: 659ff3b9691855f16d00ec5a)
time=2024-01-11T13:57:13.565Z | lvl=WARN | corr=52778eaa-b089-11ee-861c-080027cd35f1 | trans=1704981432-655-00000000007 | from=127.0.0.1 | srv=s1 | subsrv=/A | comp=Orion | op=mongoRegistrationGet.cpp[93]:setProvider | msg=Deprecated usage of legacyForwarding mode detected in existing registration (regId: 659ff3b9691855f16d00ec5a)
time=2024-01-11T13:57:13.595Z | lvl=WARN | corr=527c0912-b089-11ee-bb8c-080027cd35f1 | trans=1704981432-655-00000000008 | from=127.0.0.1 | srv=s1 | subsrv=/A | comp=Orion | op=postQueryContext.cpp[191]:queryForward | msg=Deprecated usage of legacyForwarding mode in query forwarding operation (regId: 659ff3b9691855f16d00ec5a)
time=2024-01-11T13:57:13.624Z | lvl=WARN | corr=52808938-b089-11ee-9835-080027cd35f1 | trans=1704981432-655-00000000010 | from=127.0.0.1 | srv=s1 | subsrv=/A | comp=Orion | op=postUpdateContext.cpp[163]:updateForward | msg=Deprecated usage of legacyForwarding mode in update forwarding operation (regId: 659ff3b9691855f16d00ec5a)
```

* `geo:point`, `geo:line`, `geo:box` また `geo:line` の使用
Expand Down
5 changes: 1 addition & 4 deletions doc/manuals.jp/admin/statistics.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ Orion Context broker は、`GET /statistics` と `GET /cache/statistics` を介
"counters": {
"deprecatedFeatures": {
"geoFormat": 2,
"ngsiv1Forwarding": 4,
"ngsiv1Requests": 4
"ngsiv1Forwarding": 4
},
"invalidRequests": 2,
"jsonRequests": 4,
Expand Down Expand Up @@ -113,7 +112,6 @@ SemWait ブロックは、メインの内部セマフォの累積待ち時間を
...
"timing": {
"accumulated": {
"jsonV1Parse": 7.860908311,
"jsonV2Parse": 120.680244446,
"mongoBackend": 12778.52734375,
"mongoReadWait": 7532.301757812,
Expand Down Expand Up @@ -143,7 +141,6 @@ SemWait ブロックは、メインの内部セマフォの累積待ち時間を
特定のカウンタは次のとおりです :

* `total` : HTTP ライブラリがリクエスト/レスポンス・ディスパッチ (擬似エンド・ツー・エンド時間) にかかる時間を除く、リクエスト全体の処理時間です
* `jsonV1Parse` : NGSIv1 JSON パース・モジュールで渡された時間です (疑似セルフタイム)
* `jsonV2Parse` : NGSIv2 JSON パース・モジュールで渡された時間です (疑似セルフタイム)
* `mongoBackend` : mongoBackend モジュールで渡された時間です (疑似セルフタイム)
* `render` : レンダリングモジュールに渡された時間です (擬似セルフタイム)
Expand Down
Loading
Loading