Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX remove legacyForwarding true in test that does not need it #4604

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Aug 9, 2024

This PR does a .test simplification, removing legacyForwarding: true (a deprecated feature) in test that don't need it. They are probably old test developed in the times when NGSIv2 forwarding was not fully working.

After this PR the only tree .test that use legacyForwarding: true are he following ones:

  • 0000_deprecated_checkings/log_deprecate_warning.test: which checks deprecated features logging as this one
  • 3162_context_providers_legacy_non_primitive/blanked_out_attr.test: not sure of the usage of legacyForwarding: true in this case, but this .test seems to be the regression of a particular fixed bug, so I prefer not touching it.
  • 3944_legacy_forwarding_rendering/legacy_forwarding_rendering.test: which checks the CRUD of the legacyForwarding field

In addition, note that none of these remaining test is actually implementing a NGSIv1 forwarding case. A .test for that is going to be added in PR #4603, to test the new parser developed for that.

@fgalan fgalan requested a review from mapedraza August 9, 2024 06:54
Copy link
Collaborator

@mapedraza mapedraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapedraza mapedraza merged commit 762fcb1 into master Aug 9, 2024
12 checks passed
@mapedraza mapedraza deleted the hardening/legacyforwarding-fix branch August 9, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants