Improve coverage framework #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
commented
Aug 23, 2024
There was a problem hiding this comment.
make coverage_functional_test (different from make functional_test) needs that every .test file has a different name or some omissions may occur.
We have detected 3 name repeated in .test files. This PR fix it.
NTC (informative)
fgalan
commented
Aug 23, 2024
| @@ -110,7 +110,6 @@ TEST(AppendContextElementRequest, release) | |||
| AppendContextElementRequest acer; | |||
| std::string out; | |||
| ContextAttribute* caP = new ContextAttribute("caName", "caType", "121"); | |||
| Metadata* mdP = new Metadata("mdName", "mdType", "122"); | |||
There was a problem hiding this comment.
During the preparation of this PR we detected some unused variables in unit tests.
/home/fermin/src/fiware-orion/test/unittests/convenience/AppendContextElementRequest_test.cpp:113:33: error: unused variable ‘mdP’ [-Werror=unused-variable]
113 | Metadata* mdP = new Metadata("mdName", "mdType", "122");
| ^~~
NTC (informative)
|
|
|
@fisuda this PR does some small modifications to doc/manuals/admin/build_source.md. It would be great if you could do a PR with the sync in the Japanese translation, pls. Thanks! |
fisuda
added a commit
to fisuda/fiware-orion
that referenced
this pull request
Aug 23, 2024
|
I sent the PR #4608. |
fgalan
added a commit
that referenced
this pull request
Aug 26, 2024
(JP) Add documentation about coverage framework (#4607)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4418 (and additional minor fixes)