Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 1: Information exposure through an exception #4619

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Oct 4, 2024

Fixes https://github.com/telefonicaid/fiware-orion/security/code-scanning/1

To fix the problem, we need to ensure that detailed error messages, including stack traces, are not exposed to the end users. Instead, we should log the detailed error information on the server and return a generic error message to the user. This can be achieved by modifying the record_request function to log the exception details and append a generic error message to the response string.

  1. Modify the record_request function to log the exception details instead of appending them to the response string.
  2. Ensure that the /dump endpoint returns the accumulated data without exposing sensitive error information.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant