Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use domain context object: keep info in request #498

Closed
AlvaroVega opened this issue May 11, 2022 · 3 comments
Closed

Do not use domain context object: keep info in request #498

AlvaroVega opened this issue May 11, 2022 · 3 comments

Comments

@AlvaroVega
Copy link
Member

Use request instead a domain object to store data about domainContext

Fast test:
Remove
/lib/fiware-pep-steelskin.js:233
/lib/fiware-pep-steelskin.js:317
lib/services/keystoneAuth.js:432
lib/services/cacheUtils.js:90

And store in request a dict named domain with domain context info.
This was referenced May 12, 2022
Closed
Closed
@AlvaroVega AlvaroVega mentioned this issue May 19, 2022
Merged
@fgalan
Copy link
Member

fgalan commented May 19, 2022

Fixed by PR #508

@fgalan fgalan closed this as completed May 19, 2022
@AlvaroVega
Copy link
Member Author

AlvaroVega commented May 20, 2022 •
edited by fgalan
Loading

PR #508 is related but not solves this issue

@AlvaroVega AlvaroVega reopened this May 20, 2022
This was referenced Nov 18, 2023
Merged
Merged
@fgalan
Copy link
Member

fgalan commented Nov 23, 2023

PR #528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlvaroVega @fgalan