Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete domain dependency #1

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

rg2011
Copy link

@rg2011 rg2011 commented Nov 18, 2023

Fixes issue telefonicaid/fiware-pep-steelskin#498

domain is only used to improve logging by storing information related to the request in a per-request domain. The callback provided to function getContext of logops package queries that domain to retrieve request information.

This PR replaces the global logger with a per-request instance, stored in req.logger. This instance is created by a middleware that runs early in the chain, and populated with the same information that used to be in the context.

All the middleware and handlers are also refactored to use the per-request logger instead of the global one, so we can dispose of the logger.getContext callback and the domain dependency.

@rg2011 rg2011 changed the base branch from master to release/1.15.0 November 18, 2023 12:39
fixed wrong variable

restored default values

remove obsolete library

Added missing curl needed in health checks

Updated curl doc
@rg2011 rg2011 merged commit cdf5d98 into release/1.15.0 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants