Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl and tar tool inside all docker telefonicaid objects #748

Closed

Conversation

KeshavSoni2511
Copy link
Contributor

Fix for issue #600.

  • This PR give support for curl and tar tools inside Dockerfie.

@AlvaroVega
Copy link
Member

@Keshav-NEC thanks for your contribution!
curl is used by

RELEASE=$(curl -s https://api.github.com/repos/"${GITHUB_ACCOUNT}"/"${GITHUB_REPOSITORY}"/releases/latest | grep 'tag_name' | cut -d\" -f4); \
but tar ?

@KeshavSoni2511
Copy link
Contributor Author

@Keshav-NEC thanks for your contribution! curl is used by

RELEASE=$(curl -s https://api.github.com/repos/"${GITHUB_ACCOUNT}"/"${GITHUB_REPOSITORY}"/releases/latest | grep 'tag_name' | cut -d\" -f4); \

but tar ?

Hi @AlvaroVega, support for tar was added in dockerfile because it was mentioned in issue. Thanks.

@AlvaroVega
Copy link
Member

AlvaroVega commented Sep 11, 2023

curl and tar tools are probably dependencies of other packages.
The issue #600 is wrong addressed from the beginning.

Currently all iotagent docker images are build without explicitly install curl.

@fgalan
Copy link
Member

fgalan commented Sep 11, 2023

Having closed issue #600, I'd suggest to close this PR.

@Keshav-NEC what do you think?

@KeshavSoni2511
Copy link
Contributor Author

PR closed as per comment received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants