Add support for \t in content-type header
#814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add support for XML payload * add xml checks * updated Changelog * added test case * fixed mime type checking * improved backward compatibility --------- Co-authored-by: rg2011 <[email protected]>
* add support for XML payload * add xml checks * updated Changelog * added test case * fixed mime type checking * improved backward compatibility * added cleanup of namespaces * fix upload package lock --------- Co-authored-by: rg2011 <[email protected]>
* fix issue * use synchronous error notif --------- Co-authored-by: rg2011 <[email protected]>
remove redundant test updated comments fix typo support xml bindings removed uneeded feature removed unneeded error condition simplified conditions undo uneeded changes
|
replaced by #817 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a workaround for issue #808 . The main aspects of the workaround are:
req.iswithtypeis.is. type-is is a dependency ofexpress, so this does not add new dependencies.bodyParser.xml({ ... })to add the optionbodyParser.xml({ type: () => true, ... }, which overrides the internal check of the content-type header thatbody-parser-xmldoes.parseBodyfunction to a new middlewarecheckPostContentTypethat is called before parsing the body.