Apply suggestions from code review

Co-authored-by: Fermín Galán Márquez <[email protected]>

lib/services/northBound/deviceGroupAdministrationServer.js

@@ -38,7 +38,7 @@ const mandatoryHeaders = ['fiware-service', 'fiware-servicepath'];
 const mandatoryParameters = ['resource', 'apikey'];
 const constants = require('../../constants');
 
-// Create new templeate for configuration groups replacing services by CONFIGGROUP_TERM
+// Create new template for configuration groups replacing services by CONFIGGROUP_TERM
 const templateGroup = JSON.parse(JSON.stringify(templateGroupService));
 templateGroup.properties[constants.CONFIGGROUP_TERM] = templateGroup.properties.services;
 delete templateGroup.properties.services;

test/unit/general/deviceService-test.js

@@ -210,7 +210,7 @@ describe('NGSI-v2 - Device Service: utils', function () {
         async.series([iotAgentLib.clearAll, iotAgentLib.deactivate], done);
     });
 
-    //FIXME: this test will be removed if at the end /iot/services API (now Deprecated) is removed
+    // #FIXME1649: this test will be removed if at the end /iot/services API (now Deprecated) is removed
     describe('When an existing device tries to be retrieved with retrieveOrCreate()', function () {
         beforeEach(function (done) {
             contextBrokerMock = nock('http://192.168.1.1:1026')
@@ -277,7 +277,7 @@ describe('NGSI-v2 - Device Service: utils', function () {
         });
     });
 
-    //FIXME: this test will be removed if at the end /iot/services API (now Deprecated) is removed
+    // #FIXME1649: this test will be removed if at the end /iot/services API (now Deprecated) is removed
 
     describe('When an unexisting device tries to be retrieved for an existing APIKey', function () {
         beforeEach(function (done) {

test/unit/mongodb/mongodb-configGroup-registry-test.js

@@ -1,5 +1,5 @@
 /*
- * Copyright 2015 Telefonica Investigación y Desarrollo, S.A.U
+ * Copyright 2024 Telefonica Investigación y Desarrollo, S.A.U
  *
  * This file is part of fiware-iotagent-lib
  *

test/unit/mongodb/mongodb-group-registry-test.js

@@ -23,7 +23,7 @@
  * Modified by: Daniel Calvo - ATOS Research & Innovation
  */
 
-// FIXME: parallel tests in mongodb-configGroup-registry-test.js. Remove this file if at the end /iot/services API (now Deprecated) is removed
+// #FIXME1649: parallel tests in mongodb-configGroup-registry-test.js. Remove this file if at the end /iot/services API (now Deprecated) is removed
 /* eslint-disable no-unused-vars */
 
 const iotAgentLib = require('../../../lib/fiware-iotagent-lib');

test/unit/ngsiv2/general/deviceService-test.js

@@ -210,7 +210,7 @@ describe('NGSI-v2 - Device Service: utils', function () {
         nock.cleanAll();
         async.series([iotAgentLib.clearAll, iotAgentLib.deactivate], done);
     });
-    //FIXME: this test will be removed if at the end /iot/services API (now Deprecated) is removed
+    // #FIXME1649: this test will be removed if at the end /iot/services API (now Deprecated) is removed
     describe('When an existing device tries to be retrieved with retrieveOrCreate()', function () {
         beforeEach(function (done) {
             // This mock does not check the payload since the aim of the test is not to verify
@@ -272,7 +272,7 @@ describe('NGSI-v2 - Device Service: utils', function () {
             });
         });
     });
-    //FIXME: this test will be removed if at the end /iot/services API (now Deprecated) is removed
+    // #FIXME1649: this test will be removed if at the end /iot/services API (now Deprecated) is removed
     describe('When an unexisting device tries to be retrieved for an existing APIKey', function () {
         beforeEach(function (done) {
             // This mock does not check the payload since the aim of the test is not to verify

test/unit/ngsiv2/general/iotam-autoregistration-test.js

@@ -351,7 +351,7 @@ describe('NGSI-v2 - IoT Manager autoregistration', function () {
         });
     });
 
-    //FIXME: this test will be removed if at the end /iot/services API (now Deprecated) is removed
+    // #FIXME1649: this test will be removed if at the end /iot/services API (now Deprecated) is removed
     describe('When a new service is created in the IoT Agent', function () {
         beforeEach(function (done) {
             nock.cleanAll();
@@ -422,7 +422,7 @@ describe('NGSI-v2 - IoT Manager autoregistration', function () {
         });
     });
 
-    //FIXME: this test will be removed if at the end /iot/services API (now Deprecated) is removed
+    // #FIXME1649: this test will be removed if at the end /iot/services API (now Deprecated) is removed
     describe('When a service is removed from the IoT Agent', function () {
         beforeEach(function (done) {
             nock.cleanAll();
@@ -493,7 +493,7 @@ describe('NGSI-v2 - IoT Manager autoregistration', function () {
         });
     });
 
-    //FIXME: this test will be removed if at the end /iot/services API (now Deprecated) is removed
+    // #FIXME1649: this test will be removed if at the end /iot/services API (now Deprecated) is removed
     describe('When a new service with static attributes is created in the IoT Agent', function () {
         beforeEach(function (done) {
             nock.cleanAll();

test/unit/ngsiv2/provisioning/device-group-api-test.js

@@ -23,7 +23,7 @@
 
 /* eslint-disable no-unused-vars */
 
-// FIXME: parallel tests in device-provisioning-configGroup-api_test.js.
+// #FIXME1649: parallel tests in device-provisioning-configGroup-api_test.js.
 
 const iotAgentLib = require('../../../../lib/fiware-iotagent-lib');
 const _ = require('underscore');

test/unit/ngsiv2/provisioning/device-provisioning-configGroup-api_test.js

@@ -1,5 +1,5 @@
 /*
- * Copyright 2014 Telefonica Investigación y Desarrollo, S.A.U
+ * Copyright 2024 Telefonica Investigación y Desarrollo, S.A.U
  *
  * This file is part of fiware-iotagent-lib
  *