Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mergeDeviceWithConfiguration from IOTA Lib instead of defining own function #642

Closed
fgalan opened this issue Oct 11, 2023 · 1 comment

Comments

@fgalan
Copy link
Member

fgalan commented Oct 11, 2023

While reviewing PR #640 we have realized that while IOTA-JSON uses directly the mergeDeviceWithConfiguration function from library:

https://github.com/telefonicaid/iotagent-json/blob/master/lib/iotaUtils.js#L246

In the case of IOTA-UL the same fucntion is redefined within lib/iotaUtils.js (in fact that's why PR #640 is necessary).

This is weird... IOTA-UL should aling with IOTA-JSON and use also the function directly from library (thus simplifying and gainging the advantages of code reuse).

Maybe there is a good reason (that we don't remember now :) to do the current way, in which case an explination should be provided as comment in this issue before closing it.

@fgalan
Copy link
Member Author

fgalan commented Oct 16, 2023

PR #644

@fgalan fgalan closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant