Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/propage entity name exp and timestamp type information #640

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Task/propage entity name exp and timestamp type information #640

merged 8 commits into from
Oct 11, 2023

Conversation

AlvaroVega
Copy link
Member

No description provided.

@fgalan
Copy link
Member

fgalan commented Oct 11, 2023

Is there any relationship with PR telefonicaid/iotagent-node-lib#1508 ?

@fgalan
Copy link
Member

fgalan commented Oct 11, 2023

Should a "twin" PR in IOTA-UL be done?

fgalan
fgalan reviewed Oct 11, 2023
View reviewed changes
CHANGES_NEXT_RELEASE Outdated
- Fix: ensure service and subservice from device in logs about error proccesing message
- Fix: ensure service and subservice from device in logs about error proccesing message
- Fix: use entityNameExp with autoprovisioned devices (iota-node-lib#1145)
- Fix: use timestamp from group autoprovisioned devices
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No associated issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issue

@AlvaroVega AlvaroVega changed the title Task/propage entity name exp type information Task/propage entity name exp and timestamp type information Oct 11, 2023
@AlvaroVega
Copy link
Member Author

Is there any relationship with PR telefonicaid/iotagent-node-lib#1508 ?

Yes, it's related

@AlvaroVega
Copy link
Member Author

Should a "twin" PR in IOTA-UL be done?

No twin PR for other agent is expected, it is just an expeciallitation of iotagent-node-library

@AlvaroVega AlvaroVega changed the title Task/propage entity name exp and timestamp type information [WIP] Task/propage entity name exp and timestamp type information Oct 11, 2023
@AlvaroVega AlvaroVega changed the title [WIP] Task/propage entity name exp and timestamp type information Task/propage entity name exp and timestamp type information Oct 11, 2023
mapedraza
mapedraza approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@mapedraza mapedraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fgalan
fgalan reviewed Oct 11, 2023
View reviewed changes
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
@AlvaroVega @fgalan
Update CHANGES_NEXT_RELEASE
cd1d4ae 
Co-authored-by: Fermín Galán Márquez <[email protected]>
@fgalan fgalan mentioned this pull request Oct 11, 2023
Closed
@fgalan
Copy link
Member

fgalan commented Oct 11, 2023

Should a "twin" PR in IOTA-UL be done?

No twin PR for other agent is expected, it is just an expeciallitation of iotagent-node-library

However, maybe we have an issue here. Deferred to #642

fgalan
fgalan approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit ea9d8c3 into master Oct 11, 2023
6 checks passed
@fgalan fgalan deleted the task/propage_entity_name_exp_type_information branch October 11, 2023 15:09
@fgalan fgalan mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

@mapedraza mapedraza mapedraza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvaroVega @fgalan @mapedraza