[New Feature]add normalized_emb #443
Open
+160
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhdong
reviewed
Jul 2, 2024
| @@ -240,6 +241,100 @@ def get_kv_creator(mpi_size: int, | |||
| return de.CuckooHashTableCreator(saver=saver) | |||
|
|
|||
|
|
|||
| class DynamicLayerNormalization(LayerNormalization): | |||
There was a problem hiding this comment.
Cool! It is really useful, and I recommend this layer could be a regular API, not only a demo.
rhdong
reviewed
Jul 2, 2024
| from tensorflow.keras.layers import LayerNormalization | ||
|
|
||
|
|
||
| class DynamicLayerNormalization(LayerNormalization): |
There was a problem hiding this comment.
It is recommended to keep the name of LayerNormalization and just use a different prefix sort of de.keras.layers.LayerNormalization. Accordingly, the import statement needs to be modified to from tensorflow.keras.layers import TFLayerNormalization
rhdong
reviewed
Jul 2, 2024
| DynamicLayerNormalization | ||
|
|
||
|
|
||
| class DynamicLayerNormalizationTest(tf.test.TestCase): |
There was a problem hiding this comment.
We'd better to have one case testing the scenario in which the new layer works with tfra API like the demo shows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add DynamicLayerNormalization since tf LayerNormalization doesn't support dynamic shape
Brief Description of the PR:
Fixes # (issue)
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*