Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Symfony 6.4 and attributes #5

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

middlebrain
Copy link

@middlebrain middlebrain commented Mar 18, 2024

Tested with PHP 8.2.x. All tests passed (needs my forked ext-direct branch https://github.com/middlebrain/ext-direct/tree/attribute-support).

There are two Symfony 6.4 deprecations left:

  1x: Since symfony/templating 6.4: "Symfony\Component\Templating\Helper\Helper" is deprecated since version 6.4 and will be removed in 7.0. Use Twig instead.
    1x in TQExtDirectBundleTest::testServiceDescription from TQ\Bundle\ExtDirectBundle\Tests

  1x: Since symfony/templating 6.4: "Symfony\Component\Templating\Helper\HelperInterface" is deprecated since version 6.4 and will be removed in 7.0. Use Twig instead.
    1x in TQExtDirectBundleTest::testServiceDescription from TQ\Bundle\ExtDirectBundle\Tests

I don't know, how to fix this.

If you replace

    Doctrine\Common\Annotations\AnnotationReader:
    annotation_reader: '@Doctrine\Common\Annotations\AnnotationReader'

with

    Koriym\Attributes\AttributeReader:
    annotation_reader: '@Koriym\Attributes\AttributeReader'

in

tests/TQExtDirectBundleTestConfig.yml

then the attribute tests will pass too.

I don't know how to integrate the attribute tests into the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant